From fbd65a7cbbd53a2154b7d9a3386bd1423c2a16e3 Mon Sep 17 00:00:00 2001 From: Jenny <32821331+jenny-s51@users.noreply.github.com> Date: Fri, 10 Jan 2025 13:15:14 -0500 Subject: [PATCH] apply PR feedback from Christian --- .../__tests__/cypress/cypress/pages/loginDialog.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/frontend/src/__tests__/cypress/cypress/pages/loginDialog.ts b/frontend/src/__tests__/cypress/cypress/pages/loginDialog.ts index e624ebfb63..56d852435d 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/loginDialog.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/loginDialog.ts @@ -2,7 +2,18 @@ import { Modal } from '~/__tests__/cypress/cypress/pages/components/Modal'; class LoginDialog extends Modal { constructor() { - super('Session Expired'); + super(/Session Expired/); + } + + // FIXME Remove once PF version is upgraded to 6.1.0. + // https://issues.redhat.com/browse/RHOAIENG-11946 + // https://github.com/patternfly/patternfly-react/issues/11041 + shouldBeOpen(open = true): void { + if (open) { + this.find(); + } else { + this.find().should('not.exist'); + } } find() {