From 7105242a68c90ae6447bb020dacb9619e789edcd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacobo=20Coll=20Morag=C3=B3n?= Date: Mon, 27 Jun 2022 17:15:01 +0100 Subject: [PATCH] storage: Fix IndexOutOfBoundsException using Integer element as index to remove. #TASK-1185 --- .../opencga/storage/core/metadata/models/SampleMetadata.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/opencga-storage/opencga-storage-core/src/main/java/org/opencb/opencga/storage/core/metadata/models/SampleMetadata.java b/opencga-storage/opencga-storage-core/src/main/java/org/opencb/opencga/storage/core/metadata/models/SampleMetadata.java index ac2b5c7d8c6..fac59adcab2 100644 --- a/opencga-storage/opencga-storage-core/src/main/java/org/opencb/opencga/storage/core/metadata/models/SampleMetadata.java +++ b/opencga-storage/opencga-storage-core/src/main/java/org/opencb/opencga/storage/core/metadata/models/SampleMetadata.java @@ -267,9 +267,10 @@ private void registerVersion(String versionsKey, TaskMetadata.Status status, int attributes.put(versionsKey, versions); } } else { - if (versions.contains(version)) { + int idx = versions.indexOf(version); + if (idx >= 0) { versions = new ArrayList<>(versions); - versions.remove(version); + versions.remove(idx); versions.sort(Integer::compareTo); attributes.put(versionsKey, versions); }