From 1bfb928ea03190875ac5694abe175e4b1a067502 Mon Sep 17 00:00:00 2001 From: imedina Date: Thu, 16 Feb 2023 14:49:36 +0000 Subject: [PATCH] cicd: final fix maven secrets properties --- .github/workflows/build-java-app-workflow.yml | 2 +- .github/workflows/deploy-maven-repository-workflow.yml | 5 +---- .github/workflows/task.yml | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-java-app-workflow.yml b/.github/workflows/build-java-app-workflow.yml index a138ee48..8768aa16 100644 --- a/.github/workflows/build-java-app-workflow.yml +++ b/.github/workflows/build-java-app-workflow.yml @@ -32,7 +32,7 @@ jobs: - uses: actions/upload-artifact@v3 with: name: build-folder - path: build/ + path: build - id: get_project_version uses: avides/actions-project-version-check@v1.3.0 with: diff --git a/.github/workflows/deploy-maven-repository-workflow.yml b/.github/workflows/deploy-maven-repository-workflow.yml index a09a472d..54e64005 100644 --- a/.github/workflows/deploy-maven-repository-workflow.yml +++ b/.github/workflows/deploy-maven-repository-workflow.yml @@ -26,14 +26,11 @@ jobs: fetch-depth: '10' - name: Set up JDK 8 uses: actions/setup-java@v3 - # env: - # MAVEN_USERNAME: ${{ secrets.MAVEN_NEXUS_USER }} - # MAVEN_CENTRAL_TOKEN: ${{ secrets.MAVEN_NEXUS_PASSWORD }} - # MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }} with: distribution: 'temurin' java-version: '8' cache: 'maven' + ## Future Nacho and Juanfe, please read this very carefully: DO NOT TOUCH!!! server-id: ossrh # Value of the distributionManagement/repository/id field of the pom.xml server-username: MAVEN_NEXUS_USER # env variable for username in deploy server-password: MAVEN_NEXUS_PASSWORD # env variable for token in deploy diff --git a/.github/workflows/task.yml b/.github/workflows/task.yml index bd82e6a7..34b9cc1e 100644 --- a/.github/workflows/task.yml +++ b/.github/workflows/task.yml @@ -22,7 +22,7 @@ jobs: deploy-maven: name: Deploy in maven only for renamed versions uses: opencb/java-common-libs/.github/workflows/deploy-maven-repository-workflow.yml@TASK-2270 - needs: [ build, test ] + needs: [ build ] if: contains( needs.build.outputs.version, 'SNAPSHOT') secrets: MAVEN_NEXUS_USER: ${{ secrets.MAVEN_NEXUS_USER }}