Add governance e2e tests #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Nov 25, 2024
xlc
reviewed
Nov 28, 2024
Each voter's tally and locked funds (for the track of the test's referendum, which is `SmallTipper`), are checked at 2 other important stages: 1. after the referendum's cancellation, since this event shouldn't affect either 2. after the explicit removal of such votes from the now cancelled referendum, which should alter these data accordingly.
Checking each of the test's 3 voting account's class locks and voting data was rewritten for simplicity.
xlc
reviewed
Dec 12, 2024
rockbmb
force-pushed
the
governance-e2e-tests
branch
from
735b230 to
bd9f25f
Compare
Voting events have been introduced in #4613 and #6544, but Polkadot/Kusama runtimes have not yet been updated to reflect this. Instead of storing ALL events for the transactions containing the voting extrinsics, only those for `convictionVoting` are stored i.e. they will be empty, which will trigger an error anyway when the runtimes are updated.
xlc
reviewed
Dec 16, 2024
I was going to use it for some common code from the people chain tests and these, but decided against it. |
|
/bot merge |
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #63, this PR adds E2E tests to governance functionality.
Right now, it tests a referendum's lifecycle.
This is still WIP.