From 1c2e8b20ff981873838c1543324e700e2e466dba Mon Sep 17 00:00:00 2001 From: Jaryk Date: Fri, 1 Dec 2023 20:57:56 +0100 Subject: [PATCH] feat(cucumber): support @cucumber/cucumber@10 (#1830) Co-authored-by: Daniel Dyla --- plugins/node/instrumentation-cucumber/.tav.yml | 8 ++++++-- .../node/instrumentation-cucumber/src/instrumentation.ts | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/plugins/node/instrumentation-cucumber/.tav.yml b/plugins/node/instrumentation-cucumber/.tav.yml index c1930c8cb2..a1771a240c 100644 --- a/plugins/node/instrumentation-cucumber/.tav.yml +++ b/plugins/node/instrumentation-cucumber/.tav.yml @@ -1,3 +1,7 @@ '@cucumber/cucumber': - versions: '^8.0.0 || ^9.0.0' - commands: npm test + - versions: '^8.0.0 || ^9.0.0' + node: '>=14' + commands: npm test + - versions: '^10.0.0' + node: '>=18' + commands: npm test diff --git a/plugins/node/instrumentation-cucumber/src/instrumentation.ts b/plugins/node/instrumentation-cucumber/src/instrumentation.ts index cf759ddaae..5ea3305db2 100644 --- a/plugins/node/instrumentation-cucumber/src/instrumentation.ts +++ b/plugins/node/instrumentation-cucumber/src/instrumentation.ts @@ -52,7 +52,7 @@ export class CucumberInstrumentation extends InstrumentationBase { return [ new InstrumentationNodeModuleDefinition( '@cucumber/cucumber', - ['^8.0.0', '^9.0.0'], + ['^8.0.0', '^9.0.0', '^10.0.0'], (moduleExports, moduleVersion) => { this._diag.debug( `Applying patch for @cucumber/cucumber@${moduleVersion}` @@ -86,7 +86,7 @@ export class CucumberInstrumentation extends InstrumentationBase { default: { new (): TestCaseRunner; prototype: TestCaseRunner }; }>( '@cucumber/cucumber/lib/runtime/test_case_runner.js', - ['^8.0.0', '^9.0.0'], + ['^8.0.0', '^9.0.0', '^10.0.0'], (moduleExports, moduleVersion) => { this._diag.debug( `Applying patch for @cucumber/cucumber/lib/runtime/test_case_runner.js@${moduleVersion}`