Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/splunkhec] Support passing access token via context #37307

Open
atoulme opened this issue Jan 18, 2025 · 4 comments · May be fixed by #37368
Open

[receiver/splunkhec] Support passing access token via context #37307

atoulme opened this issue Jan 18, 2025 · 4 comments · May be fixed by #37368
Labels
enhancement New feature or request receiver/splunkhec

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 18, 2025

Component(s)

receiver/splunkhec

Is your feature request related to a problem? Please describe.

The Splunk HEC receiver currently sets an access token passthrough value as a resource attribute on the payload.

Describe the solution you'd like

Instead, the receiver should set this value in the context of the request so it may be passed around to exporters without exposing a secret in the data.

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added the enhancement New feature or request label Jan 18, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@CodePrometheus
Copy link
Contributor

@atoulme hello teacher antoine, could I help in resolving this issue? I can inject it into req.Context and remove the corresponding pcommon.Resource.

@LZiHaN
Copy link
Contributor

LZiHaN commented Jan 21, 2025

@atoulme hello teacher antoine, could I help in resolving this issue? I can inject it into req.Context and remove the corresponding pcommon.Resource.

hi, when I started working on this issue, it seemed unassigned, and I wasn’t aware of others planning to address it. I’d love to hear any feedback or suggestions to improve the solution.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 21, 2025

You can take if you like, appreciated. This work is similar to what was done for SAPM receiver. I will review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/splunkhec
Projects
None yet
3 participants