Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging interface #154

Closed
jaronoff97 opened this issue Dec 20, 2022 · 3 comments
Closed

Improved logging interface #154

jaronoff97 opened this issue Dec 20, 2022 · 3 comments

Comments

@jaronoff97
Copy link
Contributor

Right now the types.Logger interface only has two methods DebugF and Errorf with the same signature format string, v ...interface{}. This makes it difficult to incorporate custom loggers which may expect err as the first parameter.

@tigrannajaryan
Copy link
Member

You can wrap a logger and implement this interface. Let me know if this is still necessary, if not I will close the issue.

@jaronoff97
Copy link
Contributor Author

@tigrannajaryan I'm coming back to this now with a similar issue. I'm wondering if we could add new methods that allow for the propagation of context. This would be similar to the slog package which allows consumers to supply a context when they would like to propagate it. I'll work on a PR to prototype this.

@tigrannajaryan
Copy link
Member

This is done in #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants