-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish interop with Circl and other implementations #910
Comments
Although more testing is generally better, both liboqs and circl already do KAT tests. They also do development at different paces.... |
And also seem to have different goals (integrations of more/different PQ algs into different apps, say). But 4 months difference (judging for example for Kyber from cloudflare/circl@6168cdb) is a bit steep, indeed. Good we now have more upstream-pull automation. --> Would anyone be in favour of setting a date for releasing liboqs 0.5? Would also be good to finally upgrade the pretty dated https://test.openquantumsafe.org to r3 (servers)... |
I've yolo-opened a discussion on release schedules here #912 |
I'm currently updating to the latest changes in some pq algorithms at CIRLC. It could be good to test between the two projects, and I can provide an status of them. |
@claucece Thanks for that update and your interest to look into this issue. In case you didn't find them yet, here's pointers to some interop test scripts we already have distributed across the various projects and that may provide thoughts:
Upon glancing at them, the latter two are particularly badly "documented" (my fault), so please don't hesitate to ask questions if you'd want to build off this if you also want run tests against the server. If you'd want to do something that runs as part of CI, I'd recommend the first link. |
Having looked into checking all KATs for each KEM (let alone signatures) I see two issues:
One way to move forward would be to test interop on the one KAT set, and then run a few more tests on randomly sampled inputs |
Sounds like a good compromise. |
@baentsch Can we close this due as having been satisfactorily resolved via open-quantum-safe/oqs-provider#278? |
OK for me if the only truly supported PQ feature CIRCL has is two specific TLS KEMs (which open-quantum-safe/oqs-provider#278 ascertains interop of). My original impression was that it is much broader in scope, both in terms of algorithms as well as protocols supported. |
You're right, there's also Dilithium and FrodoKEM in Circle. Nevermind. |
@open-quantum-safe/liboqs-committers Given the discussion around external interoperability testing in this week's meeting, perhaps it's worth adding this to an upcoming release milestone? |
@baentsch As discussed in today's OQS status call, how much of TLS hybrid interop (with Google servers, Cloudflare servers, ...?) is being done already in oqs-provider? |
Not an awful lot, see for yourself: https://github.com/open-quantum-safe/oqs-provider/blob/main/scripts/oqsprovider-externalinterop.sh Re-reading the above, this issue originally called for interop tests across all supported algorithms, not just specific hybrid TLS1.3 KEM(s). Unless we re-define the goal, this is clearly not in scope for 0.12.0 but would require a serious effort. Also, I'd add BouncyCastle as an interop target as it seems to rival if not eclipe OQS in PQC "completeness". |
Yes, fairly barebones. Thanks for looking.
Agreed. I think it's fair to say that the oqs-provider TLS interop doesn't cover the full scope of this goal. And I also agree that it's bigger in scope than we can do in 0.12.0, so I've retagged it for 0.13.0. |
Circl implements several algorithms also provided by liboqs. An automated interop test set would be good to avoid issues like #909 in the future. Possibly an application for liboqs-go?
The text was updated successfully, but these errors were encountered: