Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constant-time suppression files for Sphincs+ and McEliece generic configuration #1666

Closed
SWilson4 opened this issue Jan 16, 2024 · 0 comments · Fixed by #1683
Closed
Assignees
Milestone

Comments

@SWilson4
Copy link
Member

SWilson4 commented Jan 16, 2024

Running the constant-time tests with the generic optimization target (cmake -GNinja -DOQS_DIST_BUILD=OFF -DOQS_OPT_TARGET=generic -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON ..) results in failures for Sphincs+ and McEliece. We haven't been running CT tests for these algorithms in CI and until recently we weren't running CT tests for the generic target due to a CI configuration bug.

The full constant-time tests need to be run (locally) with the generic configuration and the suppression files updated so that there are no more failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant