You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preserving @baentsch's suggestion from #1618 so that it doesn't get buried after the merge:
I don't know how to change the "2 approvals needed" rule to only apply to certain directories -- we can apply it only to certain branches, but I don't see directories as an option.
Hmm -- just read the documentation and I also didn't find a way how to do that. A bit disappointing, I'd say. But what I did find is an option that demands approval by code owners. And that can be set to specific directories, right? So what about the idea to carefully define code ownership(s), set this flag and revert back to just 1 review needed for PRs? Not ideal if there's a sole code owner designated for some sections and that person isn't around -- in such case the 4 eyes rule would be better again...
The text was updated successfully, but these errors were encountered:
Adding users in CODEOWNERS is good practice regardless, as it should help to automatically assign reviewers. It's worth ensuring >1 owner on each area.
Having 2 reviewers is nice, and arguably important in security code as even if one is the owner, something could be missed. the question is whether it slows development down too much, especially in a small repo
Quite apart from the above, any exceptions to current or future policy could be implemented by having a github action that 'auto-approves' based on a specific encoded policy. So the basic rule would be tight, and then this allows some consessions.
Preserving @baentsch's suggestion from #1618 so that it doesn't get buried after the merge:
The text was updated successfully, but these errors were encountered: