Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy executable path" option does not enclose project path in quotes #382

Closed
ManDude opened this issue Nov 12, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@ManDude
Copy link
Member

ManDude commented Nov 12, 2023

C:\Users\Hazzy\Documents\Jak Games\versions\official\v0.2.2\gk.exe -v --proj-path C:\Users\Hazzy\Documents\Jak Games\active\jak1\data --game jak1 -- -boot -fakeiso is an invalid set of launch parameters

@ManDude ManDude added the bug Something isn't working label Nov 12, 2023
@HazzyDevil
Copy link
Contributor

HazzyDevil commented Nov 12, 2023

Quickly chiming in here. In addition to handling the enclosing of the paths correctly, assuming we are wanting users to be able to run this command from powershell, then the command the gets copied to our clipboard should be & "C:\Users\Hazzy\Documents\Jak Games\versions\official\v0.2.2\gk.exe" -v --proj-path "C:\Users\Hazzy\Documents\Jak Games\active\jak1\data" --game jak1 -- -boot -fakeiso using the example above. This will make running the game a simple copy/paste into powershell without any further work like changing directory to gk.exe and running it as that is handled by the ampersand in the command above.

Alternatively, if users are meant to run it from cmd, then the command would be "C:\Users\Hazzy\Documents\Jak Games\versions\official\v0.2.2\gk.exe" -v --proj-path "C:\Users\Hazzy\Documents\Jak Games\active\jak1\data" --game jak1 -- -boot -fakeiso as ampersand wont work here, but unfortunately this command wont work in powershell either. So probably should make it clear where the command needs to go (or an option to get either a command for powershell or cmd could work too).

Lastly, I know this isn't an issue with other applications, but gk.exe doesn't appear to like enclosing paths using single quotes ( ' ) and will error out. I figure it's worth mentioning as enclosing paths in either single or double quotes shouldn't really matter.

.\gk.exe -v --proj-path "C:\Users\Hazzy\Documents\Jak Games\active\jak1\data" --game jak1 -- -boot -fakeiso will work fine (double quotes example), but .\gk.exe -v --proj-path 'C:\Users\Hazzy\Documents\Jak Games\active\jak1\data' --game jak1 -- -boot -fakeiso doesn't work (single quote example).

@xTVaser
Copy link
Member

xTVaser commented Nov 12, 2023

Duplicate of #367

@xTVaser xTVaser marked this as a duplicate of #367 Nov 12, 2023
@xTVaser xTVaser closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants