Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[everything] option to turn off ASCII coloring #1917

Closed
ManDude opened this issue Sep 25, 2022 · 1 comment · Fixed by #2886
Closed

[everything] option to turn off ASCII coloring #1917

ManDude opened this issue Sep 25, 2022 · 1 comment · Fixed by #2886
Assignees
@xTVaser
Labels
enhancement New feature or request

Comments

@ManDude
Copy link
Member

ManDude commented Sep 25, 2022

It looks very nice, but tools like git and jenkins' consoles don't display it properly so it looks like a total mess.
@ManDude ManDude added the enhancement New feature or request label Sep 25, 2022
@xTVaser
Copy link
Member

xTVaser commented Sep 25, 2022 •
edited
Loading

I actually changed jenkins so that the colors are viewable in the "full output", ie. https://jenkins.opengoal.dev/job/jak-project/368/consoleFull (not in the trimmed logs due to jenkinsci/ansicolor-plugin#216 )

As for the CI, that is only an issue on the windows images, ive searched for a long time to find a solution but havn't been able to find one.

But yeah, this would be a nice opt-out feature for other situations.

@xTVaser xTVaser self-assigned this Feb 3, 2023
@xTVaser xTVaser mentioned this issue Aug 6, 2023
Merged
ManDude added a commit that referenced this issue Aug 8, 2023
@xTVaser @ManDude
log: rotate log files with timestamps and add flag to disable ANSI co…
5d7aa7c 
…lors (#2886)

Rotates the log files with a timestamp instead of copying all files and
incrementing an integer. Increases the amount of info you have when
looking at user's log files (ie. when looking at all the files, the file
creation dates are accurate).


![image](https://github.com/open-goal/jak-project/assets/13153231/61bcdf51-f0f6-4eee-b1e5-140aede5d19e)

Also simplifies the API for setting the log file, and `gk` logs are now
game specific with `jak1` or `jak2`. Which should be useful going
forward.

Lastly, added a flag to all CLIs to disable ansi colors for people that
want to do so. Though at the same time, there is finally a workaround in
jenkins to fix ANSI colors in the truncated log view -- so I'm not sure
why anyone would want to get rid of the color information. You can even
setup text editors to display the color info making log parsing much
easier. Fixes #1917

---------

Co-authored-by: ManDude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xTVaser xTVaser

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: rotate log files with timestamps and add flag to disable ANSI colors xTVaser/jak-project
2 participants
@ManDude @xTVaser