Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement domain scoping #249

Closed
6 tasks
beeme1mr opened this issue Mar 15, 2024 · 2 comments · Fixed by #294
Closed
6 tasks

[FEATURE] Implement domain scoping #249

beeme1mr opened this issue Mar 15, 2024 · 2 comments · Fixed by #294
Assignees
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers v0.8.0

Comments

@beeme1mr
Copy link
Member

Overview

A domain is an identifier that logically binds clients with providers, allowing multiple providers to be used simultaneously within a single application.

Domains were added to the spec in the following PR: open-feature/spec#229

Tasks

Tasks

Preview Give feedback

Reference implementations

Support was added in the JS SDK here and the Python SDK here.

Note

Some SDKs support named clients which predate domains. The domain term is intended to clarify intended behavior.

@beeme1mr beeme1mr added good first issue Good for newcomers contribfest A good issue for Contribfest KubeCon EU '24 v0.8.0 labels Mar 15, 2024
@beeme1mr beeme1mr added this to the Spec 0.8 Compliance milestone Mar 15, 2024
@benjiro benjiro self-assigned this Jul 25, 2024
@toddbaert
Copy link
Member

@benjiro I just saw you self-assigned this.

Please note that I think in the case of this SDK, there's not much work. It's mostly renaming client name, and name to domain. We basically already have this concept with named clients.

@benjiro
Copy link
Member

benjiro commented Jul 29, 2024

@benjiro I just saw you self-assigned this.

Please note that I think in the case of this SDK, there's not much work. It's mostly renaming client name, and name to domain. We basically already have this concept with named clients.

Yea I was going to do the renames over the weekend. Didnt get the time. If you want to knock it out go a head otherwise I'll try and make some time next weekend.

@toddbaert toddbaert assigned toddbaert and unassigned benjiro Aug 12, 2024
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this issue Oct 16, 2024
Uses "domain" terminology instead of "client name / named client".

Fixes: open-feature#249

I believe with this, we are able to release a 2.0

---------

Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: André Silva <[email protected]>
Signed-off-by: Artyom Tonoyan <[email protected]>
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this issue Nov 17, 2024
Uses "domain" terminology instead of "client name / named client".

Fixes: open-feature#249

I believe with this, we are able to release a 2.0

---------

Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: André Silva <[email protected]>
Signed-off-by: Artyom Tonoyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers v0.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants