Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cases where there are no intervention scenarios #22

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Handle cases where there are no intervention scenarios #22

merged 4 commits into from
Oct 9, 2024

Conversation

ConnectedSystems
Copy link
Collaborator

As in title.

@ConnectedSystems ConnectedSystems added the bug Something isn't working label Oct 9, 2024
ConnectedSystems
ConnectedSystems commented Oct 9, 2024
View reviewed changes
src/ResultStore.jl
dhw_tolerance_outplants::Ptr{Cdouble}
)::Cint

has_outplants = try
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has_outplants is not used but leaving it as is as I think it may come in handy later...

@ConnectedSystems
Copy link
Collaborator Author

pinging @Zapiano

DanTanAtAims
DanTanAtAims approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@DanTanAtAims DanTanAtAims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think there may still be some issues around appending empty iv scenarios when none were run.

@DanTanAtAims DanTanAtAims merged commit 2acecd9 into update-docs Oct 9, 2024
1 check passed
@DanTanAtAims DanTanAtAims deleted the handle-no-iv branch October 9, 2024 01:19
@ConnectedSystems ConnectedSystems mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanTanAtAims DanTanAtAims DanTanAtAims approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConnectedSystems @DanTanAtAims