feat(driver): Multi-block derivation #888
Open
+135
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashcashier
changed the title
refcell
reviewed
Jan 9, 2025
refcell
reviewed
Jan 9, 2025
Comment on lines
+43
to
+45
|
|
||
| // Wrap the cursor in a shared read-write lock | ||
| Ok(Arc::new(RwLock::new(cursor))) |
There was a problem hiding this comment.
Is there a reason you chose to return the Arc<RwLock<PipelineCursor>> instead of doing this when it's consumed?
There was a problem hiding this comment.
There's just one usage of the method in client so I thought not to clog up the client's run code.
refcell
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
PipelineCursorinstance intoOracleL2ChainProviderwhich enables the forward movement of the reference L2 block hash used to verifiably query L2 block data by number.Using this cursor in the provider enables providing authenticated data to the pipeline beyond what could previously be validating only using the commitments in
BootInfo.This allows
Driver::advance_to_targetto iteratively process multiple sequential blocks, extending the usability of Kona in ZK fault proofs.The PR also reduces some boilerplate by introducing convenience methods in
HintTypeandOracleL2ChainProvider.Closes #795