Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to search by domain/URL through all test lists #76

Open
sloncocs opened this issue Aug 8, 2023 · 4 comments
Open

Add a way to search by domain/URL through all test lists #76

sloncocs opened this issue Aug 8, 2023 · 4 comments
Assignees
Labels
enhancement New feature request or improvement to existing functionality funder/otffoss2023-2024 priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@sloncocs
Copy link

sloncocs commented Aug 8, 2023

There are cases when the URL is added to multiple test lists, e.g., 'https://www.rferl.org/' is included in 10 country-specific test lists.

Once we want to update its category, add a note, or delete all entries it is impossible to find all test lists where it is present through the Test Lists Editor.

It would be great to have a search field which would allow to find a certain domain across al test lists.

@sloncocs sloncocs added enhancement New feature request or improvement to existing functionality priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing labels Aug 8, 2023
@FedericoCeratto FedericoCeratto changed the title Add an opportunity to search by domain/URL through all test lists Add a way to search by domain/URL through all test lists Aug 8, 2023
@agrabeli
Copy link
Member

agrabeli commented Aug 8, 2023

Thanks @sloncocs for opening a ticket about this feature request. I consider it super important!

Just to share additional info/context (based on internal discussions):

The main need is being able to easily find the same URL across multiple country-specific test lists.

For example, a news media website that is relevant regionally will be included in all the country-specific test lists of that region.

So we need an easy way to find that URL across country-specific test lists, without having to open each country list one by one, searching for it...

Here's an idea:

Maybe when the user updates a URL, the Test List Editor from the backend automatically checks if the updated URL lives in another test list as well. If it does, then the user interface tells the user:

The URL entry you are updating is also available in the following test lists: XYZ. Click "Update all" if you want this contribution to apply the same changes to that URL in those lists.

Because since we can easily detect this information from the backend, we could make the Test List Editor "smart enough" to detect it, communicate it, and perhaps reflect changes everywhere in the PR.

@agrabeli
Copy link
Member

agrabeli commented Aug 8, 2023

However @hellais just mentioned that it may not be possible to search inside of the specific changeset of a user as we don’t have this data in a DB.

In this case, maybe once a PR is merged, we can run a check which checks if the updates involve a URL included in other lists?

And if so, then that can be flagged with the same updates to other lists?

I'm thinking of something like the Netlify checks which check for duplicates etc.

@agrabeli
Copy link
Member

agrabeli commented Aug 8, 2023

@FedericoCeratto suggests showing a notice for duplicates when the user starts making changes rather than when the PR is merged.

@agrabeli
Copy link
Member

agrabeli commented Aug 8, 2023

Perhaps when a user is busy editing a URL entry that exists in other lists, a sort of pop-up or other UI component for notification shows up which says:

The URL entry that you are editing also exists in the following test lists: XYZ. Would you like to apply these changes to those lists too? If so, click XYZ.

^^ Where the last XYZ links to the pages for each of those test lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement to existing functionality funder/otffoss2023-2024 priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
Status: No status
Development

No branches or pull requests

6 participants