From 3d4a624e15f1b1662c36f7524083d4242f82f84a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arturo=20Filast=C3=B2?= Date: Mon, 20 Jan 2025 16:47:35 +0100 Subject: [PATCH] Add note about web_analysis --- oonipipeline/src/oonipipeline/analysis/web_analysis.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/oonipipeline/src/oonipipeline/analysis/web_analysis.py b/oonipipeline/src/oonipipeline/analysis/web_analysis.py index e25d6359..1f09387b 100644 --- a/oonipipeline/src/oonipipeline/analysis/web_analysis.py +++ b/oonipipeline/src/oonipipeline/analysis/web_analysis.py @@ -197,6 +197,10 @@ def format_query_analysis_web_fuzzy_logic( -- We didn't get a good DNS answer, so we can't do much to analyze this result set since we -- can't trust what we saw in DNS, so we just return early and ignore this from the perspective of -- a TCP analysis + + -- TODO(art): since this being applied after the first check for success, we + -- run the risk of marking as OK TCP instances where we were able to connect to the blockpage. + -- It it correct to do so? dns_blocked > 0 AND dns_ok <= (dns_blocked + dns_down), tuple(0, 0, 0),