Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ooniapi service docs to mention maximum supported hatch version #920

Open
DecFox opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@DecFox
Copy link
Contributor

DecFox commented Jan 15, 2025

We should update the ooniapi service docs here: https://github.com/ooni/backend/tree/master/ooniapi, to explicitly mention the maximum supported hatch version for building services. This was reported by @LDiazN when trying to run services with hatch==1.14.0, which seems to not support running services.

@DecFox DecFox added the documentation Improvements or additions to documentation label Jan 15, 2025
@DecFox DecFox self-assigned this Jan 15, 2025
@hellais hellais added this to Roadmap Jan 15, 2025
@LDiazN
Copy link
Contributor

LDiazN commented Jan 15, 2025

To add a bit more context, when trying to make run (which in turn runs a hatch run ...), I was getting this error:

 File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1310, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1324, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'oonirun'
make: *** [Makefile:62: run] Error 1

This error disappeared after switching from hatch==1.14.0 to hatch==1.12.0 and deleting the old .venv

@hellais hellais removed this from Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants