-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__dirname undefined #17
Comments
|
@Doc999tor thanks for the fix provided, i will propose a PR with the fix you have mentioned. meanwhile it gets accepted and merged, and to give a little context to visitors of this issue, since i'm using esbuild to pack my lambda@edge it can be solved without modifying the code by adding |
for people following this. for edge functions in aws, you don't need this package anymore since geoheaders come for free in cloudfront. |
when deploying on edge,
__dirname
is not defined, also it's said as a best practice to bundle all js in a single file to optimize cold start. hence, the code in here:fast-geoip/index.ts
Line 12 in a5d3c6b
breaks execution of a lambda@edge using this package.
i was wondering if you had any suggestion for a suitable workaround?
The text was updated successfully, but these errors were encountered: