Github issue/pull/discussion fragments with a ? at the end are ignored and raise a warning

[onerandomusername]

URLs matched by the github link should not include question marks at the end of the url as that ends up raising an error. They should be removed and ignored.

The code where to perform this check is located around here:

monty-python/monty/exts/info/github_info.py

Lines 801 to 810 in 01838a4

	if match.re is GITHUB_ISSUE_LINK_REGEX:
	source_format = IssueSourceFormat.direct_github_url
	# handle custom checks here
	url = yarl.URL(match[0])
	# don't match if we didn't end with the hash
	if not url.path.rstrip("/").endswith(match.group("number")):
	continue
	if url.fragment or url.query: # used to match for comments later
	fragment = url.fragment

[shiftinv]

I can't think of a reason for a question mark to be there, is it really a common edge case for this?

[shiftinv]

Did a tiny bit of testing for this - it's worth mentioning that github also doesn't directly handle links like this, opening https://github.com/onerandomusername/monty-python/issues/320#issuecomment-2363522065? doesn't scroll to the comment, for instance. They do seem to account for it in their markdown parser though, since putting that link into a comment as-is looks like this:

#320 (comment)?

I haven't looked into this much, but it at least looks like they handle ?, !, ., and , and display them after the link, and it just eats other special chars like + or &. *shrug*