Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra size error case in CTS for USM alloc tests #2665

Open
martygrant opened this issue Feb 5, 2025 · 0 comments
Open

Add extra size error case in CTS for USM alloc tests #2665

martygrant opened this issue Feb 5, 2025 · 0 comments

Comments

@martygrant
Copy link
Contributor

martygrant commented Feb 5, 2025 •
edited
Loading

I've added a TODO in the CTS for urUSMDevice/Shared/HostAlloc InvalidUSMSize tests for producing a UR_RESULT_ERROR_INVALID_USM_SIZE error. The condition of size is greater than UR_DEVICE_INFO_MAX_MEM_ALLOC_SIZE is currently uncovered:

Looks like it's caused a bunch of fails, probably due to known issues with implementing UR_DEVICE_INFO_MAX_MEM_ALLOC_SIZE. I think we might just need to omit testing the upper limit on this one and let the return code be a "possible" one rather than mandatory.

Originally posted by @aarongreig in #2642 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martygrant