Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of sidebar code in React #132

Closed
Tracked by #41
danmaninc opened this issue Mar 3, 2024 · 0 comments · Fixed by #135
Closed
Tracked by #41

Remove duplication of sidebar code in React #132

danmaninc opened this issue Mar 3, 2024 · 0 comments · Fixed by #135
Assignees
@danmaninc
Labels
bug Something isn't working enhancement New feature or request

Comments

@danmaninc
Copy link
Collaborator

danmaninc commented Mar 3, 2024 •
edited
Loading

Bug description

There is duplicating code of sidebar in application.
https://github.com/one-zero-eight/InNoHassle-Website/blob/f1ce6f8304ebac3fb2f264a3aa6c682a41bf4a84/components/layout/Sidebar.tsx#L112-L178
https://github.com/one-zero-eight/InNoHassle-Website/blob/f1ce6f8304ebac3fb2f264a3aa6c682a41bf4a84/components/layout/Sidebar.tsx#L180-L229

To improve overall performance and reduce the size of html page, it would be very good to put everything in one aside element.

Suggested solution

It would be great to refactor the sidebar code. I believe that construction from scratch is the best way in this situation.

Additional context

No response
@danmaninc danmaninc mentioned this issue Mar 3, 2024
Closed
4 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in InNoHassle Mar 3, 2024
@danmaninc danmaninc added bug Something isn't working enhancement New feature or request labels Mar 3, 2024
@danmaninc danmaninc self-assigned this Mar 3, 2024
@danmaninc danmaninc moved this from 📋 Backlog to 🏗 In progress in InNoHassle Mar 3, 2024
@danmaninc danmaninc mentioned this issue Mar 17, 2024
Merged
@danmaninc danmaninc linked a pull request Mar 17, 2024 that will close this issue
refactor: remove duplication of sidebar code #135
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in InNoHassle Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danmaninc danmaninc

Labels
bug Something isn't working enhancement New feature or request
Projects
InNoHassle
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove duplication of sidebar code one-zero-eight/website
1 participant
@danmaninc