Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add DeepFilterConfigManager to core #65

Open
omeryusufyagci opened this issue Nov 2, 2024 · 0 comments
Open

Feature: Add DeepFilterConfigManager to core #65

omeryusufyagci opened this issue Nov 2, 2024 · 0 comments
Labels
core Media processing component, the core C++ binary. feature New feature or request

Comments

@omeryusufyagci
Copy link
Owner

Similar to what has been done for FFmpegConfigManager, it'd be good to add a DeepFilterConfigManager to receive user configs, settings and most importantly perform validations. This will make it much easier when using DeepFilter, as we will be able to trust that the settings are valid.

There is no ConfigManager interface. Perhaps it would've been good to have one, but we can study that need during this implementation.
@omeryusufyagci omeryusufyagci added feature New feature or request core Media processing component, the core C++ binary. labels Nov 2, 2024
@omeryusufyagci omeryusufyagci mentioned this issue Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Media processing component, the core C++ binary. feature New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

65-feature-add-deepfilterconfigmanager-to-core omeryusufyagci/fast-music-remover
1 participant
@omeryusufyagci