Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add DeepFilterCommandBuilder to MediaProcessor #32

Closed
omeryusufyagci opened this issue Oct 7, 2024 · 3 comments
Closed

Feature: Add DeepFilterCommandBuilder to MediaProcessor #32

omeryusufyagci opened this issue Oct 7, 2024 · 3 comments
Assignees
Labels
core Media processing component, the core C++ binary. feature New feature or request good first issue Good for newcomers hacktoberfest This issue is eligible for Hacktoberfest contributions help wanted Extra attention is needed

Comments

@omeryusufyagci
Copy link
Owner

Implement a DeepFilterCommandBuilder class to establish a high-level API for constructing DeepFilterNet commands, extending the CommandBuilder base class. Methods such as setInputAudio() and setNoiseReductionLevel() should abstract the command details.

This will make the filtering process more maintainable and user-friendly, eliminating the need for users to understand command-level specifics. Will be needed by the frontend for v1.0.s

DeepFilterCommandBuilder cmd;
cmd.setInputAudio(inputAudioPath);
cmd.setOutputAudio(outputAudioPath);
cmd.setNoiseReductionLevel(0.5);
// ...

See discussion in #4 for more context.

A good first issue as it's a direct extension of an existing class, requiring minimal understanding of the full project.

@omeryusufyagci omeryusufyagci added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers core Media processing component, the core C++ binary. hacktoberfest This issue is eligible for Hacktoberfest contributions labels Oct 7, 2024
@georgeolson92
Copy link
Contributor

Hey there! I wanted to see if you need some help getting this implemented. Would be happy to help!

@omeryusufyagci
Copy link
Owner Author

Hi @georgeolson92, it would be great, thanks a lot! Feel free to reach out if you have questions/feedback along the way.

@omeryusufyagci
Copy link
Owner Author

This was closed by #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Media processing component, the core C++ binary. feature New feature or request good first issue Good for newcomers hacktoberfest This issue is eligible for Hacktoberfest contributions help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants