Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional Turbo Mode #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optional Turbo Mode #227

wants to merge 1 commit into from

Conversation

jjprz
Copy link

@jjprz jjprz commented Nov 30, 2024

📄 Description

What does this Pull Request do?

  • 🐞 Bug Fix
  • ✨ New Feature
  • 🔨 Code Improvement
  • 📚 Documentation Update

✨ Key Changes

  1. Added a new configuration option to enable turbo mode.
  2. Modified the component behavior to activate turbo mode when required.
  3. Included validation to check whether turbo mode is enabled or not.

🔗 Related Issues

Fixes: #226
Related:

✅ Checklist

Please ensure the following before submitting your PR:

  • Code compiles without errors 🧑‍💻
  • All tests pass successfully ✅
  • Changes have been tested on relevant devices 🛠️
  • Documentation has been updated (if necessary) 📖
  • This PR is ready for review 🔍

🌐 Environment Information

🔢 Versions

  • ESPHome Version: 2024.10.4
  • Home Assistant Version: 2024.10.2

🧩 Devices

  • Air Conditioner Type:
    • NASA
    • NON-NASA
    • Other
  • Air Conditioner Model: AC052RNMDKG
  • Outdoor Unit Model: AC052RXADKG
  • ESP Device Model: M5STACK ATOM Lite + M5STACK RS-485
  • Wiring Configuration: F1/F2

🧪 Test Plan

How were these changes tested?

  • Device used: Tested on an air conditioner device model AC052RNMDKG with an ESP32.
  • Test cases:
    1. Verify that turbo mode can be turned on/off correctly from the user interface.
    2. Test the device's response when turbo mode is enabled.

🔍 Logs

🛠️ YAML Configuration

# Please provide the relevant YAML configuration you used for testing this PR

@omerfaruk-aran omerfaruk-aran self-assigned this Dec 5, 2024
@omerfaruk-aran
Copy link
Owner

Thank you for your PR. I’ve reviewed the changes and tested them on my device. I’d like to contribute with the following questions and suggestions:

1. Turbo Mode and Fast Cooling Overlap

  • Turbo mode was already supported among fan modes. In the current code, it seems like a true/false control has been added. What is the purpose of this addition? What is the difference between turbo mode and the Fast Cooling preset?
  • If turbo mode provides the same functionality as the Fast Cooling preset, it might be better to improve the existing preset instead of adding a new boolean control.

2. Code Clarity and Testing

  • What kind of behavior does adding turbo mode introduce? Did you observe any difference during your testing?
  • When you enable turbo mode, does the device truly switch to this mode? If yes, how did you verify this?

3. Potential Improvements

  • If turbo mode performs entirely differently, it should be clarified and integrated into the preset structure appropriately.
  • Instead of adding new functionality for an already supported feature, optimizing the existing fan modes could be more beneficial.

I look forward to your feedback on these points. Thank you for your contributions!

@omerfaruk-aran omerfaruk-aran self-requested a review December 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerfaruk-aran omerfaruk-aran Awaiting requested review from omerfaruk-aran

Assignees

@omerfaruk-aran omerfaruk-aran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NASA] Optional Turbo Mode
2 participants
@jjprz @omerfaruk-aran