Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to build Ppconsul as dynamic library on Windows #25

Open
oliora opened this issue Apr 2, 2018 · 0 comments
Open

Allow to build Ppconsul as dynamic library on Windows #25

oliora opened this issue Apr 2, 2018 · 0 comments
Labels
enhancement

Comments

@oliora
Copy link
Owner

oliora commented Apr 2, 2018

Currently it's not possible to build Ppconsul as dynamic library on Windows because dllexport/dllimport is not specified (see #24). This need to be fixed.
oliora added a commit that referenced this issue Apr 2, 2018
@oliora
On Windows build Ppconsul as static library by default
b8ac08d 
Because building as dynamic library is broken,
see #25
@oliora oliora mentioned this issue Apr 2, 2018
Closed
shdown pushed a commit to shdown/ppconsul that referenced this issue May 31, 2019
@oliora @shdown
On Windows build Ppconsul as static library by default
ac1947b 
Because building as dynamic library is broken,
see oliora#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliora