Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatumCollection#pages breaks if there are no page_ids stored #143

Open
joeljunstrom opened this issue Jan 20, 2013 · 0 comments
Open

DatumCollection#pages breaks if there are no page_ids stored #143

joeljunstrom opened this issue Jan 20, 2013 · 0 comments

Comments

@joeljunstrom
Copy link

Introduced in 774d183

$or requires the query array to be non empty which will not be the case if there are no associated pages.

Dunno what's the best solution but I suppose either we use $in and sort the result in ruby or we just skip the query if there are no page_ids and return an empty collection proxy.

ping @arvida

arvida added a commit that referenced this issue Jan 21, 2013
Temporary fix that will make DatumCollection#pages return a empty array
if there are #page_ids for collection.

  Rel. error: https://oktavilla.airbrake.io/groups/54578825/notices/7376332242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant