Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class names changed? #47

Open
Gregoire-Mercier opened this issue Apr 21, 2023 · 12 comments
Open

class names changed? #47

Gregoire-Mercier opened this issue Apr 21, 2023 · 12 comments

Comments

@Gregoire-Mercier
Copy link

Hi!
I love your code that I use from times to times since a long time.
I just tried it today and it seems that Google class names changed.
From the initial "python main.py" (of the last version) images tab is empty. I tryed to test possible class names from hand made example but I did not fix it.
Do you have the same problem from your site?
Best,
Greg

@drphero
Copy link

drphero commented Apr 21, 2023

Seem to have the same problem here. "Unable to get link"

@ohyicong
Copy link
Owner

Hi, have you downloaded the new source code? It should be patched.

@Gregoire-Mercier
Copy link
Author

I just did it one more time (from scratch with git clone) and I get:

[INFO] Image path not found. Creating a new folder.
[INFO] downloading chromedriver ver: 112.0.5615.49: https://chromedriver.storage.googleapis.com/112.0.5615.49/chromedriver_linux64.zip
[INFO] lastest chromedriver downloaded
[INFO] Gathering image links
[INFO] Unable to get link
[INFO] Unable to get link
...

@ohyicong
Copy link
Owner

It is working for my Chrome on version 112.0.5615.138. Maybe try updating your chrome?

@Gregoire-Mercier
Copy link
Author

Nope sorry...
I installed the latest Chrome google-chrome-stable_112.0.5615.165-1_amd64.deb

Then the chromedriver is the same and the broken link too:

python main.py
[INFO] downloading chromedriver ver: 112.0.5615.49: https://chromedriver.storage.googleapis.com/112.0.5615.49/chromedriver_linux64.zip
[INFO] lastest chromedriver downloaded
[INFO] Gathering image links
[INFO] Unable to get link
[INFO] Unable to get link
...

@ChristopherKurg
Copy link

I have the same issue with "[INFO] Unable to get link"

@Antz78
Copy link

Antz78 commented Apr 26, 2023

Hi Ohyicong, same code + same Chrome = same issue for me + the automatic validation of the terms of use is no longer working. Can you help ?

@Antz78
Copy link

Antz78 commented Apr 26, 2023

When weeks ago, It used to make a really great work

@utlaginn
Copy link

can confirm. all up to date.

[INFO] Unable to get link

@ohyicong
Copy link
Owner

Hi, I couldn't replicate this bug on both Windows and Ubuntu machines. I suspect that Google search results may be tagging the image with a different class name for each language. I tested this on my Google search which is running on the English version.

@Gregoire-Mercier
Copy link
Author

Hi,
The last commit you did is fine. It seems that the location does not interfer in the class names, at least by using any line as
driver.execute_cdp_cmd("Emulation.setGeolocationOverride", dict(latitude=1.290270, longitude=103.851959, accuracy=100))
Nevertheless it works fine for me now.
Thanks!
All the best.

@utlaginn
Copy link

Hi, it's working great again. Thank you, ohyicong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants