Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced older components in ResourceUpdateDetails page with Shadcn component #10202

Conversation

NikhilA8606
Copy link
Contributor

@NikhilA8606 NikhilA8606 commented Jan 26, 2025

Replaced four older components with shadcn

@rithviknishad

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

manmeetnagii and others added 29 commits January 23, 2025 22:53
…#10065)

Bumps [@rollup/rollup-linux-arm64-gnu](https://github.com/rollup/rollup) from 4.30.1 to 4.31.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.30.1...v4.31.0)

---
updated-dependencies:
- dependency-name: "@rollup/rollup-linux-arm64-gnu"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0141)

Bumps [@rollup/rollup-linux-x64-gnu](https://github.com/rollup/rollup) from 4.30.1 to 4.32.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.30.1...v4.32.0)

---
updated-dependencies:
- dependency-name: "@rollup/rollup-linux-x64-gnu"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@NikhilA8606 NikhilA8606 requested a review from a team as a code owner January 26, 2025 18:14
Jacobjeevan and others added 24 commits January 31, 2025 16:24
* fix resource letter print crash

* add TFunction

* Empty-Commit

* created new print comp for resource letter

* replace classNames with cn

* rm data from top

* Empty-Commit

* Empty-Commit

* Empty-Commit
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bodhish Thomas <[email protected]>
@AdityaJ2305
Copy link
Contributor

@NikhilA8606, what’s the status of your PR? I need to make changes to FacilitySelect, but it looks like that’s going to be removed in your PR. If that’s the case, I can skip the changes. Let me know!

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 1, 2025
@NikhilA8606
Copy link
Contributor Author

@NikhilA8606, what’s the status of your PR? I need to make changes to FacilitySelect, but it looks like that’s going to be removed in your PR. If that’s the case, I can skip the changes. Let me know!

Yes, the FacilitySelect component is going to be replaced by the Autocomplete component.

@NikhilA8606 NikhilA8606 closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required needs-triage question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.