From fe28c4e029f38e84c2708b55a3a0d9997bc61431 Mon Sep 17 00:00:00 2001
From: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>
Date: Thu, 30 Nov 2023 10:12:45 +0530
Subject: [PATCH] showing errors on wrong numbers in PhoneNumberFormField
 (#6675)

* showing errors wrong number in PhoneNumberFormField

* made error field show only when there is an error

* Update src/Components/Form/FormFields/FormField.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

* changed margin to remove extra space in userfilter

* Apply suggestions from code review

---------

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
---
 src/Components/Shifting/ListFilter.tsx |  1 -
 src/Components/Users/UserFilter.tsx    | 40 +++++++++++++-------------
 2 files changed, 20 insertions(+), 21 deletions(-)

diff --git a/src/Components/Shifting/ListFilter.tsx b/src/Components/Shifting/ListFilter.tsx
index c5b3555e8c4..ef366d5b038 100644
--- a/src/Components/Shifting/ListFilter.tsx
+++ b/src/Components/Shifting/ListFilter.tsx
@@ -410,7 +410,6 @@ export default function ListFilter(props: any) {
         name="patient_phone_number"
         value={filterState.patient_phone_number}
         onChange={handleFormFieldChange}
-        errorClassName="hidden"
         types={["mobile", "landline"]}
       />
       <DateRangeFormField
diff --git a/src/Components/Users/UserFilter.tsx b/src/Components/Users/UserFilter.tsx
index 1450e6b6f79..3dca52d2463 100644
--- a/src/Components/Users/UserFilter.tsx
+++ b/src/Components/Users/UserFilter.tsx
@@ -134,26 +134,26 @@ export default function UserFilter(props: any) {
           errors={""}
         />
       </div>
-
-      <PhoneNumberFormField
-        label="Phone Number"
-        name="phone_number"
-        placeholder="Phone Number"
-        value={filterState.phone_number}
-        onChange={handleChange}
-        errorClassName="hidden"
-        types={["mobile", "landline"]}
-      />
-
-      <PhoneNumberFormField
-        label="Whatsapp Number"
-        name="alt_phone_number"
-        placeholder="WhatsApp Phone Number"
-        value={filterState.alt_phone_number}
-        onChange={handleChange}
-        errorClassName="hidden"
-        types={["mobile"]}
-      />
+      <div className="-mb-4">
+        <PhoneNumberFormField
+          label="Phone Number"
+          name="phone_number"
+          placeholder="Phone Number"
+          value={filterState.phone_number}
+          onChange={handleChange}
+          types={["mobile", "landline"]}
+        />
+      </div>
+      <div className="-mb-4">
+        <PhoneNumberFormField
+          label="Whatsapp Number"
+          name="alt_phone_number"
+          placeholder="WhatsApp Phone Number"
+          value={filterState.alt_phone_number}
+          onChange={handleChange}
+          types={["mobile"]}
+        />
+      </div>
     </FiltersSlideover>
   );
 }