Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: rework bot commands & interactions #673

Closed
xmo-odoo opened this issue Oct 26, 2022 · 0 comments
Closed

Meta: rework bot commands & interactions #673

xmo-odoo opened this issue Oct 26, 2022 · 0 comments

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Oct 26, 2022

"Extended" commands set has issues, the priorities are a bit too non-orthogonal and leads to limited use-cases for p=1

Redo the entire commands set, to have more orthogonal and precise commands, which are easier to use and clearer:

  • remove all fuzz, if a command is unknown the comment is an error and the commenter can fuck off
  • remove numerical priorities, though maybe keep an "emergency" command which has non-trivial expansion
  • allow bypassing (non-overridable) CIs when goal is to get something merged quickly, but not so much that it's an emergency e.g. get a fix for a blocking bug that's made its way into the target branch
  • allow prioritizing PR for the next staging, but without isolating that PR or cancelling existing staging, just makes sure the PR is selected for the next staging (if otherwise suitable)
  • support attaching justifications to commands somehow, possibly require it (?)
    that's mainly for override but it could be useful for some other stuff as well
  • remove current version of skipci?
  • what happens when down-prioritising one PR of a batch where all are prioritised? (maybe reifying batches and moving prioritisation there? cf Mergebot 2 #789, such reification might also be useful or even necessary for Make staging / batch commits more easily accessible #768)

Orthogonal bits from current priority, which might be exclusive:

  • skip CI (non-overridable)
  • skip CI (all)
  • prioritise for staging (don't stage alone but really should be in next)
  • stage alone (ish)
  • cancel current staging (now? on every retry?)

Also

Retrying an emergency PR which failed should probably cancel the current staging if any.

Related:

@xmo-odoo xmo-odoo mentioned this issue Jul 4, 2023
3 tasks
xmo-odoo added a commit that referenced this issue May 29, 2024
- move all commands parsing to runbot_merge as part of the long-term
  unification effort (#789)
- set up an actual parser-ish structure to parse the commands to
  something approaching a sum type (fixes #507)
- this is mostly prep for reworking the commands set (#673), although
  *strict command parsing* has been implemented (cf update to
  `test_unknown_commands`)
@xmo-odoo xmo-odoo moved this to done in Mergebot May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

No branches or pull requests

1 participant