-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] - Would it be ok to move to using Vite ? #17
Comments
Any thoughts @sana @jerivas @jgerigmeyer? |
@VicGUTT I approve! I actually have been working on converting https://github.com/oddbird/css-anchor-positioning to use Vite (as well as some other dev-tooling changes), and then I was planning to backport those to https://github.com/oddbird/polyfill-template next week. |
Nice :) |
@VicGUTT It's up to you -- if you want to get started implementing something similar in this repo, I'd say go ahead 👍 But if you'd prefer to wait, or for me or someone else to make the changes here, that's fine too -- I should be able to look at this more this coming week. |
Great ✌️. I'll get a crack at it later today :) |
@VicGUTT See oddbird/css-anchor-positioning#10 for a sample Vite/TypeScript build process. I'm planning to backport that general approach to https://github.com/oddbird/polyfill-template this week. |
Alright, looking at now, thanks |
Before going further here, I believe it to be best for me to contribute to the other repos and wait for the general tooling backports to the downstream repos :) |
I'm wondering if it'd be ok to move to using ViteJS (which makes use of ESBuild under the hood) instead of raw ESBuild?
(Very biased/Personal) Benefits:
"build:esm:module": "esbuild src/*.ts src/*.css --outdir=dist/ --format=esm"
and other scripts won't break on my machine anymore 😅 (on Windows 👀 )The text was updated successfully, but these errors were encountered: