Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked and Locking Issues #896

Closed
Eonasdan opened this issue Sep 16, 2015 · 11 comments
Closed

Locked and Locking Issues #896

Eonasdan opened this issue Sep 16, 2015 · 11 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@Eonasdan
Copy link

Unless I missed it, there doesn't seem to be a way to filter out locked issue nor does there seem to be a way to lock an issue.

Actually, I can't find anything in the API the suggests I can do this.

Please let me know if I over looked something.

@haacked
Copy link
Contributor

haacked commented Sep 16, 2015

Hmm, I don't see it either. Perhaps @pengwynn would know.

@Eonasdan
Copy link
Author

slightly related twbs/no-carrier#3

@pengwynn
Copy link

@haacked: Locking isn't currently available via the API. I've referenced this issue on the internal feature request for that one.

@Eonasdan
Copy link
Author

image

@shiftkey
Copy link
Member

shiftkey commented Feb 2, 2016

As this is related to the GitHub product itself, rather than the API clients, I'm going to close it out.

For reference, the API is now returning locked properties for issues in Octokit (but not Pull Requests, so #1084 is that task). When the other stuff becomes available, we'll expose it in Octokit.

@shiftkey shiftkey closed this as completed Feb 2, 2016
@haacked haacked reopened this Feb 12, 2016
@haacked
Copy link
Contributor

haacked commented Feb 12, 2016

Guess what?! There's [a way to lock issues via the API now! It's in preview mode, but if someone wants to tackle it, that would be great!

@shiftkey
Copy link
Member

@cvrebert
Copy link

Finally! 😄

@prayankmathur
Copy link
Contributor

@shiftkey
@cvrebert
I have added the function in the IssueClients class.
Could you please tell me what all unit and integration tests to add ?

---------EDIT----------

I have added the unit as well as the integration tests.
I cannot run the integration tests as they skip because of a lack of a test account.
The unit tests are passing fine on my system, but they seem to have a problem running on appveyor. If you could have a look and tell me what's the problem !!.
Thanks

@shiftkey
Copy link
Member

@prayankmathur which branch is this for? If you could open a pull request it will run against our CI infrastructure - and let us see what the failures might be about...

@alexander-efremov
Copy link
Contributor

@shiftkey I think this could be closed for now 👍

@nickfloyd nickfloyd added Type: Feature New feature or request Status: Up for grabs Issues that are ready to be worked on by anyone and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants