-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sp still lingers #194
Comments
Merged
I dropped I will be working to make updates to the rest of the examples to replace the ones that use sp currently, as Todd's already done in a few places. |
See #205 for a linger-er in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sp is still imported globally in
R/package-glatos
, which errors out R CMD check.File:
https://github.com/ocean-tracking-network/glatos/blob/dev/R/package-glatos.r#L117
Error:
https://github.com/ocean-tracking-network/glatos/actions/runs/7427013555/job/20211890110#step:6:85
Could be a simple fix by removing it from
package-glatos
, but it could have big consequences if there are hidden functions still using it. Doesn't seem to have been addressed in the Todd no spatial PR, so it may not have been picked up in recent additions/checks.I might suggest removing
sp
frompackage-glatos
and putting it under Suggests in DESCRIPTION as some sp-using functions still exist (though are deprecated) and seeing what the downstream consequences are.The text was updated successfully, but these errors were encountered: