Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp still lingers #194

Open
mhpob opened this issue Jan 5, 2024 · 3 comments
Open

sp still lingers #194

mhpob opened this issue Jan 5, 2024 · 3 comments

Comments

@mhpob
Copy link
Contributor

mhpob commented Jan 5, 2024

sp is still imported globally in R/package-glatos, which errors out R CMD check.

File:
https://github.com/ocean-tracking-network/glatos/blob/dev/R/package-glatos.r#L117

Error:
https://github.com/ocean-tracking-network/glatos/actions/runs/7427013555/job/20211890110#step:6:85

Could be a simple fix by removing it from package-glatos, but it could have big consequences if there are hidden functions still using it. Doesn't seem to have been addressed in the Todd no spatial PR, so it may not have been picked up in recent additions/checks.

I might suggest removing sp from package-glatos and putting it under Suggests in DESCRIPTION as some sp-using functions still exist (though are deprecated) and seeing what the downstream consequences are.

@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

I dropped sp back into the DESCRIPTION file, and talked it over with @chrisholbrook . We're gonna let sp linger a while yet, since it's been updated to avoid the rgdal-apocalypse.

I will be working to make updates to the rest of the examples to replace the ones that use sp currently, as Todd's already done in a few places.

@jdpye jdpye closed this as completed Jan 5, 2024
@jdpye jdpye reopened this Jan 5, 2024
@mhpob
Copy link
Contributor Author

mhpob commented Jan 24, 2024

See #205 for a linger-er in convert_glatos_to_att and data(walleye_att)

@mhpob mhpob changed the title sp still lingers; errors R CMD check sp still lingers May 16, 2024
@chrisholbrook
Copy link
Collaborator

See #205 for a linger-er in convert_glatos_to_att and data(walleye_att)

fixed in 503c394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants