Vcaml does not build with OCaml 5.1 #27342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build error looks like this === ERROR while compiling vcaml.v0.16.0 ======================================# context 2.2.1 | linux/x86_64 | ocaml-base-compiler.5.1.1 | https://opam.ocaml.org#4a9170ea6d035edaf46f2af0545ca66d06561668 path ~/place/vvvcaml/_opam/.opam-switch/build/vcaml.v0.16.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p vcaml -j 7 exit-code 1 env-file ~/.opam/log/vcaml-794317-262fd9.env output-file ~/.opam/log/vcaml-794317-262fd9.out ## output ### [...] 113 | end) 114 | (Open_on_rhs_intf) 115 | () Error: The functor application is ill-typed. These arguments: $S1 Open_on_rhs_intf () do not match these parameters: functor (X : Base__Applicative_intf.For_let_syntax) (Intf : ...) (Impl : Intf.S) -> ... 1. Module $S1 matches the expected module type Base__Applicative_intf.For_let_syntax 2. Module Open_on_rhs_intf matches the expected module type 3. The functor was expected to be applicative at this position
|
trying to reprpduce locally, I'll merge afterwards |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to view the documentation of the latest released version of vcaml (v.016.0) I noticed it didn't build. Turns out, when running it on 4.14.2 it works, same on 5.0.0 but on 5.1.1 it fails.
The build error looks like this
Thus I am suggesting this upper version constraint for vcaml.