Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user to list of teams #5

Open
TotallyInformation opened this issue Mar 23, 2021 · 6 comments
Open

Add user to list of teams #5

TotallyInformation opened this issue Mar 23, 2021 · 6 comments

Comments

@TotallyInformation
Copy link

Hi, is it possible to add the invited user to a list of team names?

@obumnwabude
Copy link
Owner

Please I don't understand. How exactly do you mean? Please explain your question more

@TotallyInformation
Copy link
Author

There is a GitHub API that lets you assign users to a team in an organisation. In the GitHub admin ui, when inviting a user to an organisation, you can also select what teams you want to add them to.

So really, this package needs to be able to do something similar.

@obumnwabude
Copy link
Owner

There is a GitHub API that lets you assign users to a team in an organisation. In the GitHub admin ui, when inviting a user to an organisation, you can also select what teams you want to add them to.

So really, this package needs to be able to do something similar.

Yes you are right. That's a feature that would be nice for this package to have.

Out of the 4 different versions of this github-invite, the npm-package and frontend-only versions are accessed directly by the admin and take the admin's personal access token. I think it's okay to incorporate what you are requesting in these versions. That the admin selects the team in which the user they invite will join at invitation point, just as you are demanding. I will work towards this.

As for the Node Monolithic and Firebase versions, that just provide an interface for the invitee to be invited; I don't think it's fine to add the option for the invitee to select their team at point of themselves getting invited. Do you think it is okay to ask them to choose their teams at the point the invite themselves? Let me hear your opinion please

@TotallyInformation
Copy link
Author

Hi, thanks for the response.

We certainly wouldn't be letting invitees chose their own teams I'm afraid, that is set up front by the organisation/team administrator. We have a variety of teams who work on a variety of projects, some more sensitive than others.

@obumnwabude
Copy link
Owner

Okay, Great!

I will update the admin facing npm-package and frontend-only versions to include teams.
Thanks for raising this issue.

Is there any other feature you'll want to see?

@TotallyInformation
Copy link
Author

Great, thanks! Nothing else I can spot at the moment thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants