Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multi-AZ in HashRing Config #127

Closed
christopherzli opened this issue Jan 10, 2024 · 4 comments
Closed

Support Multi-AZ in HashRing Config #127

christopherzli opened this issue Jan 10, 2024 · 4 comments

Comments

@christopherzli
Copy link
Contributor

christopherzli commented Jan 10, 2024 •
edited
Loading

As thanos support az aware hashring config starting from v0.32: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental, we should support multi az in the controller to update config as well.
@christopherzli
Copy link
Contributor Author

pull request here: #129

@christopherzli christopherzli mentioned this issue Mar 20, 2024
Merged
@algo7
Copy link

algo7 commented May 1, 2024

This would appreciated. At the moment it seems to not support Ketama AZ-aware hashring as mentioned in Thanos official documentation here: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental

Using the config provided in Thanos doc results in the controller throwing error

level=warn caller=main.go:547 ts=2024-05-01T04:56:39.561782951Z msg="failed to decode configuration" err="json: cannot unmarshal object into Go struct field HashringConfig.endpoints of type string"

@christopherzli
Copy link
Contributor Author

thanks @algo7 , hope this PR could be reviewed soon 😄

@christopherzli
Copy link
Contributor Author

PR merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@algo7 @christopherzli