-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make Loki Compute resources configurable #72
Conversation
5b90971
to
494442b
Compare
@periklis I tried to implement what you suggested in your comment, but when testing this doesn't work for me. loki:
resources:
compactor:
limits:
cpu: 200m
memory: 200Mi
requests:
cpu: 100m
memory: 100Mi the operator just updates the CR and changes the resources to |
The implemtation in this PR is incomplete to achieve what I suggested, i.e. per component resource requirement settings. A working solution looks like this:
type LokiResourcesSpec {
Compactor *v1.ResourceRequirements
Distributor *v1.ResourceRequirements
...
}
type LokiSpec struct {
...
Resources *LokiResourcesSpec
}
|
0c0c2f6
to
8b69150
Compare
8b69150
to
3090ac0
Compare
@periklis thanks for your help! |
Resources *LokiResourcesSpec `json:"resources,omitempty"` | ||
} | ||
|
||
type LokiResourcesSpec struct { | ||
Compactor *v1.ResourceRequirements `json:"compactor,omitempty"` | ||
Distributor *v1.ResourceRequirements `json:"distributor,omitempty"` | ||
Ingester *v1.ResourceRequirements `json:"ingester,omitempty"` | ||
Querier *v1.ResourceRequirements `json:"querier,omitempty"` | ||
QueryFrontend *v1.ResourceRequirements `json:"query_frontend,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on the observatorium/observatorium#411 PR, this needs to slightly change to:
type LokiSpec struct {
Components *LokiComponentsSpec
}
type LokiComponentsSpec struct {
Compactor *LokiComponentSpec
...
}
type LokiComponentSpec {
Resources *v1.ResourceRequirements `json:"resources,omitempty"`
}
Signed-off-by: Subbarao Meduri <[email protected]>
Resolves #71
Depends on observatorium/observatorium#411
Will need to update the jsonnet dependency lock after the above PR is merged