Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timerInfo extra event #57

Open
madduck opened this issue Jan 27, 2025 · 0 comments
Open

timerInfo extra event #57

madduck opened this issue Jan 27, 2025 · 0 comments

Comments

@madduck
Copy link
Contributor

madduck commented Jan 27, 2025

Absolutely low prio this one…

When a game finished, there are 5 events being broadcast, and I want to argue that there should only be 3, or 4. Here is a simplified version of the events (note: I am rewriting the JSON data a little bit, so "timerinfo" is "timerInfo" and vice versa):

1. {"matchid": "29", …, "timerinfo": {"type": "UntilStartOfNextGame", "totalSeconds": 90}, …, "games": [1, 0], "scores": [[11, 1]], …}
2. {"matchid": "29", …, "timerinfo": null, …, "games": [1, 0], "scores": [[11, 1]], …}
3. {"matchid": "29", …, "timerinfo": {"type": "UntilStartOfNextGame", "totalSeconds": 15}, …, "games": [1, 0], "scores": [[11, 1]], …}
4. {"matchid": "29", …, "timerinfo": null, …, "games": [1, 0], "scores": [[11, 1]], …}
5. {"matchid": "29", …, "timerinfo": null, …, "games": [1, 0], "scores": [[11, 1]], …}

Event 2 could be the addition of [0, 0] to the scores, in which case events 4 and 5 can be dropped.
Alternatively (preferred) drop 2 and 4, and make 5 appear when the timer expires, or the game is started manually, adding [0, 0] to the scores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant