Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to choose derivation path on Ledger connect #905

Closed
clicman opened this issue Jul 5, 2022 · 2 comments
Closed

Add an ability to choose derivation path on Ledger connect #905

clicman opened this issue Jul 5, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request ledger Ledger ux Usability, user experience etc.

Comments

@clicman
Copy link

clicman commented Jul 5, 2022

For example to choose between [44, 474, 0, 0, i] and [44, 474, i] and maybe another options

@pro-wh pro-wh added enhancement New feature or request ux Usability, user experience etc. ledger Ledger labels Jul 7, 2022
@matevz
Copy link
Member

matevz commented Jul 8, 2022

Hey @clicman,

there's a PR for the web wallet which enables this #761, but we decided not to merge it until we implement some advanced switch. The wallet should be idiot-proof across the Oasis ecosystem and users will get confused, if there will be two derivation paths suddenly available - one of them not supported by the older versions of the wallet. If you want to use Ledger with the derivation path defined in ADR-8 ([44, 474, i]), use Oasis CLI for now.

@matevz matevz closed this as completed Jul 8, 2022
@matevz matevz added the duplicate This issue or pull request already exists label Jul 8, 2022
@matevz
Copy link
Member

matevz commented Jul 8, 2022

Closing - duplicate of #760 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request ledger Ledger ux Usability, user experience etc.
Projects
None yet
Development

No branches or pull requests

3 participants