New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awkward code (nit) #3

Open

bennetyee opened this issue Jan 23, 2019 · 0 comments

Member

bennetyee commented Jan 23, 2019

instead of

battleship-demo/core/game/src/lib.rs

Line 114 in 3b44b0e

for x_offset in 0..=2 {

and then

battleship-demo/core/game/src/lib.rs

Line 116 in 3b44b0e

let x = coord.0 + x_offset - 1;

i think doing

for x_offset in -1..=1 {
  ...
  let x = coord.0 + x_offset;

would be more natural / readable.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment