Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous test that makes code less readable #2

Open
bennetyee opened this issue Jan 23, 2019 · 0 comments
Open

extraneous test that makes code less readable #2

bennetyee opened this issue Jan 23, 2019 · 0 comments

Comments

@bennetyee
Copy link
Member

Tile::Ship(id) if id != ship_id => false,

the if test is unnecessary because the ship is not placed on the board until L130-L134.

also, instead of using the valid boolean, this match could just continue the random-placement loop (add a label at

might be more readable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant