Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup/restore logic for required files #61

Open
andywaltlova opened this issue Feb 16, 2024 · 0 comments
Open

Backup/restore logic for required files #61

andywaltlova opened this issue Feb 16, 2024 · 0 comments

Comments

@andywaltlova
Copy link
Collaborator

Talked with @kokesak about the possible improvement of the c2r repo (required files) download logic.

Now the script does:

  1. Setup (includes download of gpg key and repo files) - files are always downloaded, if they exist they are backed up
  2. Check if convert2rhel is installed
  3. Install/update of ocnvert2rhel pkg

Now this works nicely, but the issue we had about urlopen error got us thinking if we need to download them every time. Question here is if it does matter from where the convert2rhel package was installed on the system or do we care only about the fact that it is there? What would happen if it would be older version and because of wrong repo we wouldn't be able to update it?

This updated steps would work too, but it would introduce the possibility of failed update of convert2rhel pkg.

  1. Check if convert2rhel is installed
  2. Optional Setup (includes download of gpg key and repo files) - only if convert2rhel pkg is not installed
  3. Install/update of convert2rhel pkg

Is there a legit use case where customer would already have the convert2rhel pkg fro mdifferent source and wouldn't have the possibility (or simply wouldn't want) to download our required files? (=the urlerror would block him)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant