Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fine-grained check levels #78

Open
nuest opened this issue Oct 9, 2018 · 0 comments
Open

Add more fine-grained check levels #78

nuest opened this issue Oct 9, 2018 · 0 comments
Labels

Comments

@nuest
Copy link
Member

nuest commented Oct 9, 2018

As of now, the check is binary. This requires the outputs to be pixel-perfect, whereas reality might require a human reviewer to make that call. Therefore we should discuss to loosen the binary nature of the check and...

  • consider adding different result levels, better distinguishing
  • consider not requiring images to be pixel perfect - can the checker distinguish between grayscale changes and completely different curves in a graph?
  • consider allowing reviewers to override a result (transparently), maybe with a specific status check_overruled ?
@nuest nuest added the question label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant