Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Boolean env vars parsing #74

Open
shimkiv opened this issue Apr 6, 2023 · 0 comments
Open

Fix Boolean env vars parsing #74

shimkiv opened this issue Apr 6, 2023 · 0 comments
Assignees
@MartinMinkov
Labels
bug Something isn't working

Comments

@shimkiv
Copy link
Member

shimkiv commented Apr 6, 2023

By default any non-empty string env var in condition like this if (process.env.VAR) { will be parsed into boolean: true. So we need to check against another string if (process.env.VAR === 'true') {.
@shimkiv shimkiv added the bug Something isn't working label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinMinkov MartinMinkov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shimkiv @MartinMinkov