Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NyprOPersistentAudioPlayer has dependencies not in nypr-design-system #194

Open
Sticksword opened this issue Apr 8, 2021 · 0 comments
Open

Comments

@Sticksword
Copy link

When installing nypr-design-system in a fresh Ember 3.25 app, I ran into missing dj service so I installed nypr-audio-services. Then I encountered this error:

Uncaught Error: Assertion Failed: Attempting to inject an unknown injection: 'service:dataLayer'

I believe when the original audio player was ported from nypr-jukeboxes, the additional service dependencies were not accounted for. 21ffa58

For the unknown injection error, I believe we need to either refactor to pass in necessary properties for this component or port over the services necessary from https://github.com/nypublicradio/nypr-jukeboxes/tree/main/app/services.

Would love to start a discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant