Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better contact field editing feedback #401

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Conversation

ericnewcomer
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 88.95899% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 78.93%. Comparing base (32eb519) to head (2b17962).

Files Patch % Lines
src/contacts/ContactFieldEditor.ts 92.10% 18 Missing ⚠️
src/contacts/ContactFields.ts 66.66% 16 Missing ⚠️
src/textinput/TextInput.ts 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   78.78%   78.93%   +0.14%     
==========================================
  Files          79       79              
  Lines       21362    21631     +269     
  Branches      709      735      +26     
==========================================
+ Hits        16831    17074     +243     
- Misses       4524     4550      +26     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericnewcomer ericnewcomer merged commit 840d9ed into main Mar 17, 2024
4 checks passed
@ericnewcomer ericnewcomer deleted the contact-field-feedback branch March 17, 2024 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant