Add support for WhatsApp templates not syncing notfications #398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.02%
==========================================
Files 78 78
Lines 20994 20997 +3
Branches 686 686
==========================================
Hits 16521 16521
- Misses 4466 4469 +3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
src/list/NotificationList.ts
Outdated
| @@ -76,6 +76,9 @@ export class NotificationList extends TembaList { | |||
| } else if (notification.incident.type === 'channel:disconnected') { | |||
| icon = Icon.channel; | |||
| body = 'Your android channel is not connected'; | |||
| } else if (notification.incident.type === 'templates:unsynced') { | |||
There was a problem hiding this comment.
I think i'd call this something like channel:templates_failed since like channel:disconnected it applies to a specific channel... and we're not syncing so much as fetching.
There was a problem hiding this comment.
That is more than 20 characters limit we have on Incident type.
Should I change the limit there to like 32 or 64? @rowanseymour
There was a problem hiding this comment.
Just wanted to reiterate how unfortunate it is this requires a component change.
There was a problem hiding this comment.
@norkans7 yeah let's do 32
@ericnewcomer maybe not ideal but we're adding new incident types very rarely.. like contact event types for the chat component
There was a problem hiding this comment.
I guess I'm still on the fence about JSON endpoints returning HTML...
norkans7
force-pushed
the
WA-templates-sync-incident
branch
from
1ab2e47 to
2db805f
Compare
Related to nyaruka/rapidpro#5073