Make char limits on result name and category on set_run_result actions consistent with routers
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s be consistent with routers
rowanseymour
commented
Dec 2, 2024
| @@ -112,6 +112,9 @@ export default class SetRunResultForm extends React.PureComponent< | |||
| } | |||
|
|
|||
| private handleCreateAssetFromInput(input: string): Asset { | |||
| // workaround for the lack of a length limit on the form itself | |||
| input = input.substring(0, 64); | |||
There was a problem hiding this comment.
this is the Result Name entered as an arbitrary option on a tembaselect
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 64.43% 64.43% -0.01%
==========================================
Files 181 181
Lines 7095 7096 +1
Branches 1680 1680
==========================================
Hits 4572 4572
- Misses 1943 1944 +1
Partials 580 580 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.