From 137f986e32e5a507d3c331a11297ac328d020a9a Mon Sep 17 00:00:00 2001 From: Rowan Seymour Date: Mon, 2 Dec 2024 20:39:09 +0000 Subject: [PATCH] Make char limits on result name and category on set_run_result actions be consistent with routers --- src/components/flow/actions/setrunresult/SetRunResultForm.tsx | 3 ++- .../setrunresult/__snapshots__/SetRunResultForm.test.ts.snap | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/flow/actions/setrunresult/SetRunResultForm.tsx b/src/components/flow/actions/setrunresult/SetRunResultForm.tsx index 0ec1ea37e..ccd392dfa 100644 --- a/src/components/flow/actions/setrunresult/SetRunResultForm.tsx +++ b/src/components/flow/actions/setrunresult/SetRunResultForm.tsx @@ -160,6 +160,7 @@ export default class SetRunResultForm extends React.PureComponent< onChange={this.handleValueUpdate} entry={this.state.value} autocomplete={true} + maxLength={64} helpText={i18n.t( 'forms.result_value_help', 'The value to save for this result or empty to clears it. You can use expressions, for example: @(title(input))' @@ -173,7 +174,7 @@ export default class SetRunResultForm extends React.PureComponent< onChange={this.handleCategoryUpdate} entry={this.state.category} autocomplete={false} - maxLength={128} + maxLength={36} helpText={i18n.t( 'forms.result_category_help', "An optional category for your result. For age, the value might be 17, but the category might be 'Young Adult'" diff --git a/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap b/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap index 29a7d3d2f..d97270be1 100644 --- a/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap +++ b/src/components/flow/actions/setrunresult/__snapshots__/SetRunResultForm.test.ts.snap @@ -81,6 +81,7 @@ exports[`SetRunResultForm render should render 1`] = ` } } helpText="The value to save for this result or empty to clears it. You can use expressions, for example: @(title(input))" + maxLength={64} name="Value" onChange={[Function]} showLabel={true} @@ -94,7 +95,7 @@ exports[`SetRunResultForm render should render 1`] = ` } } helpText="An optional category for your result. For age, the value might be 17, but the category might be 'Young Adult'" - maxLength={128} + maxLength={36} name="Category" onChange={[Function]} placeholder="Optional"